"I see floating lava but no ores." Solution: The pack is working, but you are in a bad biome. Extreme Hills mountains have the highest diamond generation. Go there.
Not all X-Ray packs are created equal. When searching for an "X Ray Minecraft 1.12 2 texture pack," look for these specific features: x ray minecraft 1.12 2 texture pack